Skip to content

Add option to add and update additional scan profile details #5697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Mar 11, 2025
Merged

Conversation

flozia
Copy link
Collaborator

@flozia flozia commented Mar 11, 2025

Duplicate of closed PR #5660 to workaround a stuck Deploy Preview Action.

References:

Jira: MNTOR-4065
Figma: https://www.figma.com/design/2iCgADpFXKOFZTEgCPkQsR/Settings?node-id=597-10052&t=c2UkGyKPdbvneuz5-4

Description

Adds additional scan profile details and the option to update them:

  1. The migration file for the changes in this PR is split out to PR Migration for PR #5660 #5664.
  2. Updates the /admin/dev panel to add the option to test the backend changes.

How to test

  1. Run the migrations: npm run db:migrate
  2. Run an initial welcome scan
  3. Enable the feature flag EditScanProfileDetails
  4. Make sure you can still run an initial scan
  5. Visit /admin/dev
  6. Make changes to the scan profile
  7. Confirm any profile updates are applied to the table onerep_profiles and also show for the remote profile

Checklist (Definition of Done)

  • Commits in this PR are minimal and have descriptive commit messages.
  • I've added or updated the relevant sections in code comments
  • I've added a unit test to test for potential regressions of this bug.
  • All acceptance criteria are met.
  • Jira ticket has been updated with suggestions for QA when this PR is deployed to stage.

@flozia flozia requested review from Vinnl, rhelmer and mansaj March 11, 2025 10:27
@flozia flozia closed this Mar 11, 2025
@flozia flozia removed the request for review from Vinnl March 11, 2025 10:34
@flozia flozia removed request for rhelmer and mansaj March 11, 2025 10:34
@flozia
Copy link
Collaborator Author

flozia commented Mar 11, 2025

Closed as reopening PR #5660 seems to be sufficient for rerunning the Deploy Preview Action.

@Vinnl Vinnl reopened this Mar 11, 2025
Copy link

@flozia flozia merged commit 9f2be07 into main Mar 11, 2025
37 of 40 checks passed
@flozia flozia deleted the mntor-4065 branch March 11, 2025 11:14
Copy link

Cleanup completed - database 'blurts-server-pr-5697' destroyed, cloud run service 'blurts-server-pr-5697' destroyed

@flozia flozia mentioned this pull request Apr 23, 2025
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants