Skip to content
This repository was archived by the owner on Jan 7, 2025. It is now read-only.

Rule fixes based on QA report #260 #269

Merged
merged 4 commits into from
Nov 22, 2023
Merged

Rule fixes based on QA report #260 #269

merged 4 commits into from
Nov 22, 2023

Conversation

abhishekmadan30
Copy link
Contributor

No description provided.

@abhishekmadan30 abhishekmadan30 requested a review from a team as a code owner November 8, 2023 21:48
Trikolon
Trikolon suggested changes Nov 10, 2023
View reviewed changes
Copy link
Member

@Trikolon Trikolon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating so many rules! I've found a few issues for which I've added comments inline.

Please also run npm run test locally and make sure it passes. This checks for both rule validity and formatting issues.

@Trikolon Trikolon changed the title Fixed QA cooke banner bugs Rule fixes based on QA report #260 Nov 14, 2023
Trikolon
Trikolon suggested changes Nov 16, 2023
View reviewed changes
Copy link
Member

@Trikolon Trikolon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please mark comments you addressed as "resolved" so it's easier to see what work is still pending.

@Trikolon Trikolon mentioned this pull request Nov 16, 2023
Open
@cadeyrn cadeyrn mentioned this pull request Nov 17, 2023
Open
@Trikolon
Copy link
Member

Trikolon commented Nov 20, 2023 •
edited
Loading

@abhishekmadan30 make sure you rebase on the latest version of main. This still seems to have conflicts as per the message below.

Trikolon
Trikolon suggested changes Nov 21, 2023
View reviewed changes
Copy link
Member

@Trikolon Trikolon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found one more issue, otherwise the changes look good. Thanks!

Trikolon
Trikolon approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@Trikolon Trikolon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Trikolon Trikolon merged commit 9beea7f into mozilla:main Nov 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Trikolon Trikolon Trikolon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abhishekmadan30 @Trikolon