Ebay international sites

[MikeFH]

Update rule to add other ebay domains.
I took the list of domains used here :
https://pages.ebay.com/securitycenter/security_researchers_eligible_domains.html

[Greg-21]

I already had changes similar to yours prepared locally and just waiting to be published, but since you were quicker, I will share with you for the benefit of all of us what I managed to achieve :)

Here is the whole rule with additional domains added (it looks like I managed to find 2 more than you) sorted alphabetically, so that it would be easier to see which ones are still missing and add more when needed, and with simplified selectors so as not to waste those milliseconds unnecessarily:

{
  "id": "1e6d35e7-b907-4f5c-a09a-9f3336ef6e61",
  "domains": [
    "ebay.at",
    "ebay.be",
    "ebay.ca",
    "ebay.ch",
    "ebay.co.uk",
    "ebay.com",
    "ebay.com.au",
    "ebay.com.hk",
    "ebay.com.my",
    "ebay.com.sg",
    "ebay.de",
    "ebay.es",
    "ebay.fr",
    "ebay.ie",
    "ebay.it",
    "ebay.nl",
    "ebay.ph",
    "ebay.pl",
    "ebay.vn"
  ],
  "click": {
    "presence": "#gdpr-banner",
    "optOut": "#gdpr-banner-decline",
    "optIn": "#gdpr-banner-accept"
  }
}

[MikeFH]

If you have your changes ready, I think it would be better if you open a PR and I close this one.
I like your changes better than mine tbh.

Regarding the two domains ebay.vn and ebay.ph, for some reason they seem broken so I didn't include them since I couldn't test the rule.
For example this is what I see when I go to ebay.ph

[Greg-21]

There is really no need for you to close this pull request. If you like my changes better, feel free to just copy the code from my earlier comment and commit it. I don't care about any credit, I just want people to be able to use Firefox without those annoying cookie banners, especially if someone enabled automatic cookie deletion when the browser is closed, like me.

As for the ebay.ph and ebay.vn websites, it appears that some resources are blocked and/or not served at all on your end. However, for me, both of them display just fine. Here's a screenshot as proof:

[MikeFH]

I thought about it and it bothers me to just copy and paste your changes. I feel that it would be easier and safer if you just use your own branch to open a PR.
I can assure you I don't have a problem with that at all.

PS : I found what was blocking content on ebay.ph and ebay.vn and it's the Firefox strict tracking protection which blocks certain ebay domains and that causes problems on those two specific domains.