Skip to content

Enterprise: Handle browser crash #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lissyx merged 1 commit into from
Jan 14, 2026
Merged

Enterprise: Handle browser crash #291

lissyx merged 1 commit into from
Jan 14, 2026

Conversation

@lissyx
Copy link
Contributor

@lissyx lissyx commented Dec 17, 2025

UX is open to discussion.

@lissyx lissyx self-assigned this Dec 17, 2025
@lissyx lissyx requested a review from a team December 17, 2025 14:56
@lissyx lissyx requested review from 1rneh and gcp December 17, 2025 15:00
@lissyx lissyx force-pushed the enterprise-handle_crashes branch from 6f4ba5c to 343de12 Compare December 18, 2025 08:19
@lissyx lissyx force-pushed the enterprise-handle_crashes branch from b78cbeb to b9def40 Compare January 9, 2026 23:51
@lissyx lissyx requested a review from gcp January 12, 2026 14:25
@lissyx
Copy link
Contributor Author

lissyx commented Jan 13, 2026

I'll fix the lint issues here, and keep this UX for now. We will improve later.

@1rneh
Copy link
Contributor

1rneh commented Jan 13, 2026 •
edited
Loading

I'll fix the lint issues here, and keep this UX for now. We will improve later.

As discussed last week, please get the UX approved by Matt and add the correct designs first.

1rneh
1rneh requested changes Jan 13, 2026
View reviewed changes
Copy link
Contributor

@1rneh 1rneh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As re-discussed, if this is urgent to land, because QA needs the visible feedback about the crashes, then I'm ok with landing this now and follow-up on the UX once that is defined.

Additionally I have some suggestions about the code structure.

@lissyx lissyx force-pushed the enterprise-handle_crashes branch from b9def40 to 5854a51 Compare January 13, 2026 18:38
1rneh
1rneh requested changes Jan 14, 2026
View reviewed changes
Copy link
Contributor

@1rneh 1rneh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Just some smaller things... Only important thing left is to clarify the intention of the time period.

@lissyx lissyx force-pushed the enterprise-handle_crashes branch from 5854a51 to 6f896cd Compare January 14, 2026 13:57
@lissyx lissyx requested a review from 1rneh January 14, 2026 13:57
1rneh
1rneh approved these changes Jan 14, 2026
View reviewed changes
Copy link
Contributor

@1rneh 1rneh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm now, thanks!

@lissyx lissyx force-pushed the enterprise-handle_crashes branch from 6f896cd to 69e6d2e Compare January 14, 2026 14:41
@gcp gcp mentioned this pull request Jan 14, 2026
Open
@lissyx lissyx merged commit ebc8254 into enterprise-main Jan 14, 2026
1 check passed
@lissyx lissyx deleted the enterprise-handle_crashes branch January 14, 2026 14:58
gcp
gcp reviewed Jan 14, 2026
View reviewed changes
browser/extensions/felt/content/styles/felt.css
/* stylelint-disable-next-line */
left: 8px;
font-size: medium;
/* stylelint-disable-next-line stylelint-plugin-mozilla/use-design-tokens */
Copy link
Contributor

@gcp gcp Jan 14, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this lint exception actually needed? Didn't you forget to remove this?

Copy link
Contributor

@1rneh 1rneh Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, https://treeherder.mozilla.org/logviewer?job_id=543562202&repo=enterprise-firefox-pr&task=DGk37lvMQKqsKjfUW9OEYA.0&lineNumber=212. We agreed that once we have a well defined crash ux, this will be revamped anyhow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gcp gcp gcp requested changes

@1rneh 1rneh 1rneh approved these changes

Assignees

@lissyx lissyx

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lissyx @1rneh @gcp