Enterprise network informations device posture #300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lissyx
commented
Dec 19, 2025
lissyx
force-pushed
the
enterprise-network_informations_device_posture
branch
from
f72fa07 to
54e0723
Compare
lissyx
force-pushed
the
enterprise-network_informations_device_posture
branch
from
54e0723 to
9e16467
Compare
lissyx
force-pushed
the
enterprise-network_informations_device_posture
branch
from
9e16467 to
eded123
Compare
lissyx
force-pushed
the
enterprise-network_informations_device_posture
branch
from
fdba88a to
2fea1cb
Compare
lissyx
force-pushed
the
enterprise-network_informations_device_posture
branch
4 times, most recently
from
d22d50e to
6841b7c
Compare
gcp
reviewed
Jan 14, 2026
lissyx
commented
Jan 14, 2026
|
|
||
| nsTArray<NetworkInterface> networkInterfaces; | ||
| for (const auto& linkInfo : mLinks.Values()) { | ||
| if (linkInfo->mIsUp) { |
Contributor
Author
There was a problem hiding this comment.
https://searchfox.org/firefox-main/rev/5917a9f2af3294b27a325371c5c499e7dd9554fd/netwerk/system/netlink/NetlinkService.cpp#258-261 so we dont report loopback on linux @gcp
lissyx
force-pushed
the
enterprise-network_informations_device_posture
branch
from
6841b7c to
ba8a011
Compare
lissyx
commented
Jan 14, 2026
|
|
||
| #if defined(MOZ_ENTERPRISE) | ||
| // Skip non up interfaces as well as loopback | ||
| networkInterfaces.AppendElement(NetworkInterface(adapter)); |
Contributor
Author
There was a problem hiding this comment.
@gcp moved this so we skip loopback interfaces
lissyx
commented
Jan 14, 2026
Comment on lines
1020
to
1052
| if (!(ifa->ifa_flags & IFF_UP)) { | ||
| continue; | ||
| } | ||
|
|
||
| if (ifa->ifa_flags & IFF_LOOPBACK) { | ||
| continue; | ||
| } | ||
|
|
||
| if (!(ifa->ifa_flags & IFF_RUNNING)) { | ||
| continue; | ||
| } | ||
|
|
||
| int s = socket(ifa->ifa_addr->sa_family == AF_LINK ? AF_INET : ifa->ifa_addr->sa_family, SOCK_DGRAM, 0); | ||
| if (s < 0) { | ||
| continue; | ||
| } | ||
|
|
||
| struct ifmediareq ifmr; | ||
| memset(&ifmr, 0, sizeof(ifmr)); | ||
| strlcpy(ifmr.ifm_name, ifa->ifa_name, sizeof(ifmr.ifm_name)); | ||
|
|
||
| if (ioctl(s, SIOCGIFXMEDIA, (caddr_t)&ifmr) < 0) { | ||
| close(s); | ||
| continue; | ||
| } | ||
|
|
||
| if (!(ifmr.ifm_status & IFM_ACTIVE)) { | ||
| close(s); | ||
| continue; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
@gcp this allows up to skip interfaces that are:
- not up or not running
- loopback
- or dont report as active on the media level
lissyx
force-pushed
the
enterprise-network_informations_device_posture
branch
from
ba8a011 to
5a251f4
Compare
lissyx
commented
Jan 15, 2026
lissyx
force-pushed
the
enterprise-network_informations_device_posture
branch
2 times, most recently
from
0e8e673 to
b8b552c
Compare
lissyx
force-pushed
the
enterprise-network_informations_device_posture
branch
from
b8b552c to
6e78d7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.