FxCI: Skip shippable builds for PRs ; add tests #303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lissyx
force-pushed
the
enterprise-shippable_pgo
branch
from
704df8f to
737e5ab
Compare
lissyx
force-pushed
the
enterprise-shippable_pgo
branch
from
737e5ab to
258b1f2
Compare
lissyx
force-pushed
the
enterprise-shippable_pgo
branch
from
258b1f2 to
6423793
Compare
lissyx
force-pushed
the
enterprise-shippable_pgo
branch
from
b628a6c to
b442666
Compare
ahal
reviewed
Jan 12, 2026
ahal
requested changes
Jan 12, 2026
Member
ahal
left a comment
ahal
left a comment
There was a problem hiding this comment.
Looks reasonable! Main issue is to remove the worker-type hack.
lissyx
force-pushed
the
enterprise-shippable_pgo
branch
from
b442666 to
ba88d51
Compare
Contributor
Author
|
Somehow we dont run tests on debug builds? |
Contributor
We don't, for cost reasons (it's much slower on CI). This means, unfortunately, that's not uncommon to start crashing on an unrelated thing when you make a debug build to debug something... |
lissyx
force-pushed
the
enterprise-shippable_pgo
branch
from
ba88d51 to
b85dfe3
Compare
ahal
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.