Refactor updating enterprise policies #321
Open
+320
−328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
1rneh
commented
Jan 8, 2026
1rneh
commented
- Refactor updating remote policies
- Fix merging policies of a combined provider when remote policies are updated
gcp
reviewed
Jan 9, 2026
| @@ -381,6 +482,8 @@ EnterprisePoliciesManager.prototype = { | |||
|
|
|||
| this._status = Ci.nsIEnterprisePolicies.UNINITIALIZED; | |||
| this._parsedPolicies = undefined; | |||
| this._provider = null; | |||
| this._topicsObserved = null; | |||
| case "policies-startup": | ||
| // Before the first set of policy callbacks runs, we must | ||
| // initialize the service. | ||
| this._initialize(); | ||
| await this._initialize(); |
Contributor
There was a problem hiding this comment.
Don't the callers need to know about this? They would assume things are already initialized when this returns, but it's not? So you'd get new race conditions?
gcp
reviewed
Jan 9, 2026
| ); | ||
|
|
||
| if (!isValid) { | ||
| continue; |
Contributor
There was a problem hiding this comment.
This will cause the policy to be removed because it doesn't go in parsedPolicies, unclear if that is what you want.
Contributor
Author
There was a problem hiding this comment.
Good point! I didn't change that behavior. But let's re-think this :)
We have two options when encountering invalid parameters:
- Policy is currently active: We can remove the policy or keep it active with unchanged parameters. I think I prefer the latter. It's seems more intentional. In both ways we can warn in the logs about invalid parameters.
- Policy is currently inactive: Do nothing.
gcp
reviewed
Jan 9, 2026
| @@ -381,6 +482,8 @@ EnterprisePoliciesManager.prototype = { | |||
|
|
|||
| this._status = Ci.nsIEnterprisePolicies.UNINITIALIZED; | |||
| this._parsedPolicies = undefined; | |||
| this._provider = null; | |||
Contributor
There was a problem hiding this comment.
I think we can't actually do this unless we stop the RemotePoliciesProvider polling first, because that sends the Update message, and processing that assumes that _provider is non-null.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.