Enterprise: Check -felt for profile selection only on startup #334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcp
requested changes
Jan 13, 2026
toolkit/xre/nsAppRunner.cpp
Outdated
| file.forget(aRootDir); | ||
| localDir.forget(aLocalDir); | ||
| // Background tasks never use profiles known to the profile service. | ||
| aProfile = nullptr; |
Contributor
There was a problem hiding this comment.
nsIToolkitProfile** aProfile so this probably doesn't do what you want. But how did we get here....given that this should have been copypasted?
Contributor
Author
There was a problem hiding this comment.
I may have mistakenly broke it
|
|
||
| NS_ENSURE_SUCCESS(rv, rv); | ||
|
|
||
| if (didCreate) { |
Contributor
There was a problem hiding this comment.
You're now bypassing this logic and the checks that follow.
Contributor
Author
There was a problem hiding this comment.
We were never changing either aDidCreate nor aIsResetting, so I dont think we regress anything here
Doing it in SelectStartupProfile() was somehow hitting race condition leading to a segfault while running some tests, the stack including XPCOM version of it.
lissyx
force-pushed
the
enterprise-check_profile_arg_only_startup
branch
from
6795db2 to
b94dfac
Compare
gcp
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing it in SelectStartupProfile() was somehow hitting race condition leading to a segfault while running some tests, the stack including XPCOM version of it.