Enterprise repack default console #344
Open
+175
−63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lissyx
force-pushed
the
enterprise-repack_default_console
branch
from
0c33392 to
9fc92d0
Compare
ahal
reviewed
Jan 15, 2026
| ]["locales"]: | ||
| if platform_name == build_platform: | ||
| repack_final_name = f"{enterprise_name}/{repack_name}/{repack_locale}" | ||
| if repack_final_name not in repacks: |
Member
There was a problem hiding this comment.
Consider making repacks a set so you don't need to test for existence.
| if platform_name == build_platform: | ||
| repack_final_name = f"{enterprise_name}/{repack_name}/{repack_locale}" | ||
| if repack_final_name not in repacks: | ||
| repacks += [repack_final_name] |
Member
There was a problem hiding this comment.
Try:
from itertools import product
repacks = set()
for enterprise_name, repack_configs in this_repack.items():
for repack_name, config in repack_configs.items():
repacks.update([
f"{enterprise_name}/{repack_name}/{locale}"
for platform, locale in product(config["platforms"], config["locales"]):
if platform == build_platform
]) Haven't tested but should be equivalent.
lissyx
force-pushed
the
enterprise-repack_default_console
branch
3 times, most recently
from
5d5535a to
3d19a20
Compare
lissyx
force-pushed
the
enterprise-repack_default_console
branch
from
3d19a20 to
9b3838b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.