Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(next): reuse subscription item fetch logic #18540

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

StaberindeZA
Copy link
Contributor

Because

  • Reuse function to retrieve subscription item from subscription.

This pull request

  • Move retrieveSubscriptionItem into util function and reuse in invoice.manager.
  • Extract logic to fetch upcoming upgrade invoice into previewUpcomingUpgrade method.
  • Rewrite previewUpcomingForUpgrade to more accurately reflect its purpose.

Issue that this pull request solves

Closes: (issue number)

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

Any other information that is important to this pull request.

Because:

- Reuse function to retrieve subscription item from subscription.

This commit:

- Move retrieveSubscriptionItem into util function and reuse in
  invoice.manager.
- Extract logic to fetch upcoming upgrade invoice into
  previewUpcomingUpgrade method.
- Rewrite previewUpcomingForUpgrade to more accurately reflect its
  purpose.

Closes #
@StaberindeZA StaberindeZA requested a review from a team as a code owner March 12, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant