add PKCE to SessionRefresh middleware and refactor #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
escattone
force-pushed
the
consider-PKCE-in-session-refresh-middleware
branch
13 times, most recently
from
5d138cc to
e3f1e26
Compare
escattone
force-pushed
the
consider-PKCE-in-session-refresh-middleware
branch
2 times, most recently
from
75bf68b to
7ee4bc5
Compare
escattone
force-pushed
the
consider-PKCE-in-session-refresh-middleware
branch
from
7ee4bc5 to
ae4ca3c
Compare
akatsoulas
reviewed
Jan 9, 2024
| @@ -159,3 +162,88 @@ def add_state_and_verifier_and_nonce_to_session( | |||
| "nonce": nonce, | |||
| "added_on": time.time(), | |||
| } | |||
|
|
|||
|
|
|||
| class AuthorizationCodeRequestMixin: | |||
There was a problem hiding this comment.
Although it makes a lot of sense to introduce this mixin and use it in both places, I am concerned that introducing this change will also introduce complexity and it will make it harder to modify/debug/override code. Thoughts?
There was a problem hiding this comment.
@akatsoulas and I discussed the pros and cons of this via video. Closing this in favor of #515.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #397 (comment).