-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Precendence order documentation according implementation #314
Conversation
I don't know, after looking this part, I don't like the current integration. We should have something like that : After a long reflection, I think this can be better :
I don't understand : can be overridden using the We speak only about loadFile and load because const config = convict({ port: { default: 3000 } }
config.load({ port: 8080 });
console.log(config.get('port')); // 8080
config.set('port', 433);
console.log(config.get('port')); // 443
config.load({ port: 9000 });
console.log(config.get('port')); // 9000 |
@A-312 Thank you for a review. I did not think about complete rewrite of this block, but it make sense in order to make it clear. I'll update the PR later |
ping @zaverden |
@A-312 sorry for delay. I have updated description and moved can be overridden using the env|args option to a separate section |
This PR is ready |
@madarche This one is ready |
@zaverden Can you rebase your PR in mozilla:feat-multi-packages-split ? Is the branch for the next update (6.0.0). |
@A-312 done |
Fixes #211
Fixes #208