Skip to content

Coerce from strings to their proper types (NOT MORE) + code review on coercing #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
A-312 wants to merge 10 commits into from
Closed

Coerce from strings to their proper types (NOT MORE) + code review on coercing #352

A-312 wants to merge 10 commits into from

Conversation

@A-312
Copy link
Contributor

@A-312 A-312 commented Jan 1, 2020

This PR is the same of #339, because I can't reopen #339, I create a new PR.

Fix: #338

The code review in this PR prepare custom getter #313.

A-312 and others added 6 commits December 15, 2019 18:30
@A-312 @madarche
[Remove dependencies] Convert some default format to external package (…
19e7f9f 
…#327)

Multi-packages split
@madarche
Update CHANGELOG
9066f56
@madarche
Regenerating package-lock.json
30bcc2e 
with current NPM registry state
@A-312
fix test
653cbc4 
should be "describe > it" not "it > it" because it cannot contain other it.
@A-312
Coerce from strings to their proper types (NOT MORE)
b1dea14 
 - Remove placeholder test because : "since code too complicated already and only works in limited cases" (see : 812cd15)
 - #262 will be able to do it with custom getter.
@A-312
Remove not used argument in addDefaultValues
ad6b246
@coveralls
Copy link

coveralls commented Jan 1, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 9c853ba on A-312:coerce-too-many-arg into 30bcc2e on mozilla:feat-multi-packages-split.

A-312 added 4 commits January 1, 2020 11:22
@A-312
code review : coerce function need only 2 args
5951c72 
We need to use `traverseSchema` only with `config.set`
@A-312
code review : variable names more accurate and use const instead let
e249059 
when we don't need to change the variable value
@A-312
code review : magic coerceing - Save the format name in schema
fbd4cea 
No implicit format, set absolute format (to help debug with config.getSchema())
@A-312
add magic_corceing test
9c853ba
This was referenced Jan 1, 2020
Closed
Closed
Closed
@madarche madarche force-pushed the feat-multi-packages-split branch from 7064166 to 051dd99 Compare March 6, 2020 17:48
@A-312 A-312 closed this Mar 6, 2020
@A-312 A-312 deleted the coerce-too-many-arg branch March 6, 2020 18:44
@A-312 A-312 mentioned this pull request Apr 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@A-312 @coveralls @madarche