Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #1095. Fix some potential NPEs in Parser.java. #1099

Merged
merged 1 commit into from
Dec 9, 2021
Merged

Fix issue #1095. Fix some potential NPEs in Parser.java. #1099

merged 1 commit into from
Dec 9, 2021

Conversation

MaxisTekfield
Copy link
Contributor

I've fixed the issue #1095 .

Closes #1095

@p-bakker
Copy link
Collaborator

Any idea if this PR makes #394 obsolete?

@MaxisTekfield
Copy link
Contributor Author

I think PR #394 has already been covered by PR #987 .
This PR fixes other potential NPEs while dereferencing ts in Parser.

@p-bakker
Copy link
Collaborator

Tnx, I've closed #394

@gbrail gbrail merged commit cfa48f5 into mozilla:master Dec 9, 2021
@gbrail
Copy link
Collaborator

gbrail commented Dec 9, 2021

This looks good to me. I'm going to merge it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Found some potential NPEs in Parser.java and patch PR is on the road.
3 participants
@MaxisTekfield @p-bakker @gbrail