Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non deterministic behaviour with vararg methods #1433

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Non deterministic behaviour with vararg methods #1433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6a5c919
Provide failing test case
rPraml Jan 2, 2024
99f6d09
FIX: method discovery
rPraml Jan 2, 2024
a8d5e23
Merge branch 'master-upstream' into varargs
rPraml Aug 22, 2024
7e5369e
Merge branch 'master-upstream' into varargs
rPraml Sep 6, 2024
5af151e
Provided additional tests
rPraml Sep 6, 2024
ebac11c
fixes
rPraml Sep 6, 2024
3af04ae
Spotless + enabled tests
rPraml Sep 6, 2024
542b0f7
More tests. Still in progress
rPraml Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion rhino/src/main/java/org/mozilla/javascript/JavaMembers.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import java.util.ArrayList;
import java.util.Arrays;
import java.util.HashMap;
import java.util.LinkedHashMap;
import java.util.List;
import java.util.Locale;
import java.util.Map;
Expand Down Expand Up @@ -306,7 +307,8 @@ private Object getExplicitFunction(
*/
private Method[] discoverAccessibleMethods(
Class<?> clazz, boolean includeProtected, boolean includePrivate) {
Map<MethodSignature, Method> map = new HashMap<>();
Map<MethodSignature, Method> map =
new LinkedHashMap<>(); // use linked hash map for deterministic discovery
discoverAccessibleMethods(clazz, map, includeProtected, includePrivate);
return map.values().toArray(new Method[0]);
}
Expand Down
Loading
Loading