-
Notifications
You must be signed in to change notification settings - Fork 858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial implementation of function rest parameter support #1451
Conversation
…tions are not supported as of now)
…rameter support
I have been having a really hard time finding time to work on Rhino these days as it's completely not part of my work world any more. Thanks for taking up a lot of the duties! This particular PR looks good to me -- I also tried it and I can see that it handles the basics as described in the spec. My only particular very minor comment is about the error message -- if we don't have a French translation of a particular message, can't we leave it out of the "_fr" message catalog and have Java fall back to the generic message? I see that you copied the English into the French message catalog and I don't believe that has worked in the past. Thanks -- I am happy to merge this if we change that one tiny thing. |
@gbrail good point -done |
This looks good now -- thanks! |
@rbri saw my question above? |
@p-bakker yes and yes, description is correct, arrow functions are not supported by this PR |
K, thnx for the info! |
arrow functions are not supported as of now