Add support for super inside eval
#1736
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
andreabergia
force-pushed
the
super-eval
branch
from
3f6e5d7 to
9e832e2
Compare
Co-authored-by: Satish Srinivasan <satish.srinivasan@servicenow.com>
andreabergia
force-pushed
the
super-eval
branch
from
9e832e2 to
4309510
Compare
Co-authored-by: Satish Srinivasan <satish.srinivasan@servicenow.com>
gbrail
requested changes
Dec 3, 2024
See spec 13.5.1.2 at https://tc39.es/ecma262/#sec-delete-operator-runtime-semantics-evaluation Co-authored-by: Satish Srinivasan <satish.srinivasan@servicenow.com>
Co-authored-by: Andrea Bergia <andrea.bergia@servicenow.com>
gbrail
approved these changes
Dec 6, 2024
Co-authored-by: Satish Srinivasan <satish.srinivasan@servicenow.com>
andreabergia
force-pushed
the
super-eval
branch
from
4309510 to
d9e91d5
Compare
|
Merged onto #1735 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR, co-authored with @0xe , implements
supersupport insideeval. It is stacked on top of #1735.The semantics come for "free", i.e. trying to resolve
superwhen doingevalworks automatically because it will do the same logic as a nested arrow function, i.e. look it up from the activation (theNativeCall).So, the changes are really only related to the parser and need to allow
superinsideeval. We have implemented this by adding a new flag inCompilerEnvironsthat is filled automatically during anevalcall. We have chosen this approach because it allowssuperto be used in other places, such as a debugger's watch or immediate evaluation.