Handle delete super.x by throwing an error
#1739
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
andreabergia
force-pushed
the
super-delete
branch
from
0874113 to
765a292
Compare
Co-authored-by: Satish Srinivasan <satish.srinivasan@servicenow.com>
Co-authored-by: Satish Srinivasan <satish.srinivasan@servicenow.com>
andreabergia
force-pushed
the
super-delete
branch
from
765a292 to
4f0f761
Compare
gbrail
approved these changes
Dec 3, 2024
See spec 13.5.1.2 at https://tc39.es/ecma262/#sec-delete-operator-runtime-semantics-evaluation Co-authored-by: Satish Srinivasan <satish.srinivasan@servicenow.com>
andreabergia
force-pushed
the
super-delete
branch
from
4f0f761 to
5a3d4e2
Compare
|
Merged this onto #1735 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR, co-authored with @0xe, adds support for
delete super.x. It is stacked on top of #1735.The ECMAScript spec says that this is not allowed, but it has to be a runtime error and not a syntax error. Therefore, we have generated a new bytecode instruction that will just do the throw at runtime.