Allow symbol keys in getter/setter in object literal syntax #1749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreabergia
force-pushed
the
getter-setter-symbol-key
branch
2 times, most recently
from
4c7e556 to
cc69848
Compare
gbrail
approved these changes
Dec 10, 2024
andreabergia
force-pushed
the
getter-setter-symbol-key
branch
from
cc69848 to
2541f12
Compare
|
Rebased. |
|
Yes, I'm afraid that we need one more rebase of that big old test262.properties file. Thanks! |
andreabergia
force-pushed
the
getter-setter-symbol-key
branch
from
2541f12 to
dafd20f
Compare
|
Rebased again. I would suggest not squashing this. |
|
Thanks -- looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows syntax such as:
to work correctly. I've also done a bit of refactoring of the tests in
ComputedPropertiesTestto useUtils.runWithAllOptimizationLevelsinstead of having three functions for each case.Should fix #1614