Fixed computed property in object literal with negative integers #1752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a code path, in compiled mode only (not in interpreted!),
where something like `o = { [-1]: xxx }` would not work correctly.
The problem is a combination of factors:
- in the interpreter, we would treat `-1` as a `double`, not an `int`;
- but there are various places in `ScriptRuntime` where integer keys
are allowed _only_ for positive or zero numbers, per the spec -
otherwise they need to be treated as strings.
We have modified the existing test for computed properties and fixed
the code.
Co-authored-by: Satish Srinivasan <satish.srinivasan@servicenow.com>
Merged
|
Yes, good catch, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a code path, in compiled mode only (not in interpreted!), where something like
o = { [-1]: xxx }would not work correctly.The problem is a combination of factors:
-1as adouble, not anint;ScriptRuntimewhere integer keys are allowed only for positive or zero numbers, per the spec - otherwise they need to be treated as strings.We have modified the existing test for computed properties and fixed the code.