Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more detailed test output (see #909) #910

Closed
wants to merge 3 commits into from

Conversation

rbri
Copy link
Collaborator

@rbri rbri commented May 24, 2021

i know this is a bit of a hack but i like to focus on fixing this cases instead of making super cool code here

@gbrail
Copy link
Collaborator

gbrail commented May 25, 2021

Thanks -- this is helpful.

How do you feel about having it always print out the list of tests that didn't pass in all cases, versus only printing if a system property or something is set? We'll have to look at those messages for quite a long time as I suspect that some of them will take a while to fix.

@rbri
Copy link
Collaborator Author

rbri commented May 26, 2021

@tonygermano, @tuchida, @p-bakker what do you think?

}
}

public String getMessage(int[] optLevels) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't Optional<String> getMessage better?
https://docs.oracle.com/javase/8/docs/api/java/util/Optional.html

@p-bakker
Copy link
Collaborator

Very useful indeed.

Do wonder if a different format would be better (and doable), one where the results aren't encoded in a string like fails in strict mode but passes in non-strict mode for all opt level(s) -1, 0, 9, but where I could take to output and parse it (for example a csv format and pasting it into Excel) and then analyse it.

For example to find all tests that fail on all optLevels in either strict or non-strict mode or find all tests that always fail in non-interpreted mode

@gbrail
Copy link
Collaborator

gbrail commented May 26, 2021

Thinking more about this...

I'm afraid that if we add lots of output to a "successful" build then we'll end up masking other problems because people will just ignore everything.

I would prefer if this instead printed out one message like this:

Warning:
27 tests failed in strict mode but passed in non-strict mode
99 tests failed for some optimization levels and passed for others
See buildGradle/reports/inconsistent-tests.txt for detail

@rbri
Copy link
Collaborator Author

rbri commented Jun 16, 2021

#930 is the future

@rbri rbri closed this Jun 16, 2021
@rbri rbri deleted the better_Test262SuiteTest_outpur branch August 19, 2021 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants