-
Notifications
You must be signed in to change notification settings - Fork 861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
more detailed test output (see #909) #910
Conversation
Thanks -- this is helpful. How do you feel about having it always print out the list of tests that didn't pass in all cases, versus only printing if a system property or something is set? We'll have to look at those messages for quite a long time as I suspect that some of them will take a while to fix. |
@tonygermano, @tuchida, @p-bakker what do you think? |
} | ||
} | ||
|
||
public String getMessage(int[] optLevels) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't Optional<String> getMessage
better?
https://docs.oracle.com/javase/8/docs/api/java/util/Optional.html
Very useful indeed. Do wonder if a different format would be better (and doable), one where the results aren't encoded in a string like For example to find all tests that fail on all optLevels in either strict or non-strict mode or find all tests that always fail in non-interpreted mode |
Thinking more about this... I'm afraid that if we add lots of output to a "successful" build then we'll end up masking other problems because people will just ignore everything. I would prefer if this instead printed out one message like this: Warning: |
#930 is the future |
i know this is a bit of a hack but i like to focus on fixing this cases instead of making super cool code here