Address suggestions

mozilla · Jan 29, 2025 · d047ca9 · d047ca9
1 parent 1dcc012
commit d047ca9
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/tests/ui/perfherder/legend_card_test.jsx b/tests/ui/perfherder/legend_card_test.jsx
@@ -25,7 +25,7 @@ const testData = [
     signature_id: 1647493,
     visible: true,
     suite: 'tp5o_webext',
-    shouldAlert: true,
+    shouldAlert: null,
     alertChangeType: 1,
     alertThreshold: 2.0,
   },
@@ -46,6 +46,8 @@ const testData = [
     visible: true,
     suite: 'tp5o_webext',
     shouldAlert: null,
+    alertChangeType: 1,
+    alertThreshold: 2.0,
   },
 ];
 
@@ -118,7 +120,7 @@ test('legend card displays the shouldAlert value', async () => {
 
   const shouldAlert = await waitFor(() => queryByText('should_alert: true'));
   const alertChangeType = await waitFor(() =>
-    queryByText('alert_change_type: 1'),
+    queryByText('alert_change_type: absolute'),
   );
   const alertThreshold = await waitFor(() => queryByText('alert_threshold: 2'));
 

diff --git a/ui/perfherder/graphs/LegendCard.jsx b/ui/perfherder/graphs/LegendCard.jsx
@@ -208,8 +208,12 @@ const LegendCard = ({
           </Button>
         )}
         <Badge> {framework} </Badge>
-        <div className="small">{`should_alert: ${series.shouldAlert}`}</div>
-        <div className="small">{`alert_change_type: ${series.alertChangeType}`}</div>
+        <div className="small">{`should_alert: ${
+          series.shouldAlert !== false
+        }`}</div>
+        <div className="small">{`alert_change_type: ${
+          series.alertChangeType === 1 ? 'absolute' : 'percentage'
+        }`}</div>
         <div className="small">{`alert_threshold: ${series.alertThreshold}`}</div>
         <div className="small">{`${series.signatureHash.slice(0, 16)}...`}</div>
       </div>