Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:BranchEvent.h not found on SPM package #51

Conversation

mmustafa-tse
Copy link
Contributor

@mmustafa-tse mmustafa-tse commented Nov 14, 2023

Reference

https://mparticle-eng.atlassian.net/browse/PRODRDMP-6014

Summary

A customer noted that adding the Branch kit as an SPM package resulted in BranchEvent.h not found and I was able to reproduce

Motivation

Bug fix

Testing Instructions

E2E testing locally, added the package locally to the higgs project and the "BranchEvent.h not found" error disappeared after implementing the code change

Copy link
Contributor

@BrandonStalnaker BrandonStalnaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BrandonStalnaker BrandonStalnaker merged commit 7372179 into mparticle-integrations:development Nov 14, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants