Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update Branch to 3.4.1 up to next major #59

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

einsteinx2
Copy link
Contributor

We were previous fuzzy pinning to 3.0.1, which for SPM works as expected (up to next major), but for CocoaPods, was limited updates to 3.0.x only. There is a new privacy manifest fix for Cocoapods in 3.4.1, so I've adjusted our fuzzy pinning to 3.4 for cocopods so it will pull in any 3.x.x release >= 3.4 (which will currently be 3.4.1) and bumped SPM to match (but used 3.4.1 because SPM has sane matching options). Unfortunately there is no way to set 3.4.1 as the min version for Cocoapods while also pinning to next major, which is why I used 3.4.

Tested in both a Cocoapods and SPM test app to see that it pulls in the correct dependencies and builds properly. No E2E required for this as SPM was already pulling in that version automatically.

Copy link
Contributor

@BrandonStalnaker BrandonStalnaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@einsteinx2 einsteinx2 merged commit 8f031b0 into development Apr 9, 2024
3 checks passed
@einsteinx2 einsteinx2 deleted the feat/6326-update-branch-dependency branch April 9, 2024 14:23
mparticle-automation added a commit that referenced this pull request Apr 9, 2024
# [8.4.0](v8.3.0...v8.4.0) (2024-04-09)

### Features

* Update Branch to 3.4.1 up to next major ([#59](#59)) ([8f031b0](8f031b0))
@mparticle-automation
Copy link
Collaborator

🎉 This PR is included in version 8.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants