Add wrapping and scaling methods to class Box#50
Open
PhilLecl wants to merge 1 commit intomphowardlab:mainfrom
Open
Add wrapping and scaling methods to class Box#50PhilLecl wants to merge 1 commit intomphowardlab:mainfrom
PhilLecl wants to merge 1 commit intomphowardlab:mainfrom
Conversation
Contributor
|
Thank you! This will be a nice feature to have available, and we will work to add some tests for it soon. I would also welcome a pull request to support reading from / writing to scaled or unwrapped coordinates when you are ready. Could you open an issue so we can discuss that before you do so? I'd like to discuss a plan for that first, particularly whether multiple of those are allowed to be in a dump file and how lammpsio will transform them when they're read in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #11
This adds methods for converting wrapped/unwrapped and scaled/real coordinates.
I also have a (rudimentary) implementation for reading dumps with scaled and/or unwrapped coordinates at https://github.com/PhilLecl/lammpsio/tree/read-dump-su.
I've used it together with the dumps generated by the input script below to test the calculations.
Note that unwrapping can cause the floating point error to become rather large.