Small fix to catch JSON stringify errors within Writer.publish

mpneuried · Jul 25, 2017 · 5bb59f0 · 5bb59f0
1 parent f1488c9
commit 5bb59f0
Show file tree

Hide file tree

Showing 5 changed files with 3,130 additions and 15 deletions.
diff --git a/README.md b/README.md
@@ -530,6 +530,7 @@ The writer is connected to `nsqd`
 ## Release History
 |Version|Date|Description|
 |:--:|:--:|:--|
+|0.1.3|2017-07-25|Small fix to catch JSON stringify errors within `Writer.publish`|
 |0.1.2|2016-07-22|Fixed a stupid error with the host config of the writer|
 |0.1.1|2016-07-19|Removed debugging output|
 |0.1.0|2016-07-15|Updated dependencies [Issue#2](https://github.com/mpneuried/nsq-logger/issues/2) and optimized activate [Issue#3](https://github.com/mpneuried/nsq-logger/issues/3)|

diff --git a/_src/test/main.coffee b/_src/test/main.coffee
@@ -39,7 +39,7 @@ describe "----- nsq-logger TESTS -----", ->
 			return
 		return
 
-	after: ( done )->
+	after ( done )->
 		testServers.stop( done )
 		return
 

diff --git a/_src/writer.coffee b/_src/writer.coffee
@@ -66,7 +66,14 @@ class NsqWriter extends require( "./basic" )
 		if _isString( data )
 			_data = data
 		else
-			_data = JSON.stringify(data)
+			try
+				_data = JSON.stringify(data)
+			catch _err
+				if cb?
+					cb( _err )
+				else
+					@error( "stringify data for topic `#{topic}`", _err )
+				return
 
 		@client.publish @nsAdd( topic ), _data, ( err )=>
 			if err