Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sandbox abstraction proposal #273

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Sandbox abstraction proposal #273

wants to merge 7 commits into from

Conversation

mptre
Copy link
Owner

@mptre mptre commented Jan 1, 2018

Related to GitHub issue #269 and #271.

@mptre mptre force-pushed the sandbox branch 6 times, most recently from 72cf664 to 84f36c8 Compare January 3, 2018 17:53
@mptre mptre force-pushed the sandbox branch 7 times, most recently from 1b78616 to cebf2cd Compare January 6, 2018 11:00
@calleluks
Copy link
Collaborator

This is really cool! Thanks for the great work @DBOTW and @mptre. Should #274 be merged into the branch for this PR?

It's not clear to me why the build is failing or why it's not outputting "disallowed syscall" messages.

@mptre
Copy link
Owner Author

mptre commented Jan 13, 2018

It's not clear to me why the build is failing or why it's not outputting "disallowed syscall" messages.

I've been trying to figure out why the disallowed message doesn't show
up on Travis. Even strace:ing pick shows that the write call succeeds. I
got a bit reluctant to shipping support for seccomp after reading
this. The plan was to make make check || cat test-suite.log output
the missing syscall to ease debugging on platforms experiencing
failures.

@ghost
Copy link

ghost commented Jan 14, 2018

I got a bit reluctant to shipping support for seccomp

seccomp should be disabled by default but can be used with --enable-seccomp ...
(latest #274 has been modified accordingly)

@ghost
Copy link

ghost commented Jan 17, 2018

Quoting google/sanitizers#777 (comment):

Our general suggestion is to disable any sandboxes in sanitizer builds.

... I'm doing so in latest #274 ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants