console.lua: disable cursor autohide while selector is open

[verygoodlee]

This is an improvement on #15145 .
If the cursor is automatically hidden, users may not know whether they are clicking on the inside or outside of selectable items, the result after clicking is unclear to them.

[guidocella]

I'm not sure if this is needed anyway but note that I already implemented a proper background with a horizontal hitbox so you can close by clicking outside of it horizontally, I'm just waiting for #15711 to be merged:

We can then unbind right click like you asked if wanted.

[github-actions]

Download the artifacts for this pull request:

Windows

• mpv-i686-w64-mingw32
• mpv-x86_64-w64-mingw32
• mpv-x86_64-windows-msvc

macOS

• mpv-macos-13-intel
• mpv-macos-14-arm
• mpv-macos-15-arm

[verygoodlee]

this looks pretty nice, similar to uosc, I have just tried the uosc and the cursor cannot be hidden while menu is open.

[guidocella]

Yeah I blatantly copied uosc's menu since it looked better.

[Dudemanguy]

Since #15711 got merged, do we need this anymore?

[verygoodlee]

Since #15711 got merged, do we need this anymore?

I think we still need this since uosc has same behavior.

[guidocella]

Needs rebase. Since you can now seamlessly go from input.select -> input.get without going through set_active, cursor-autohide can be restored within unbind_mouse().

I'm not sure on the other hand if disabling cursor-autohide should go inside bind_mouse(), this would also disable it when searching the command history, and while I made sure the new hitbox works with it, this may be unwanted since I doubt anyone uses the mouse for that (currently it's not even useful in upstream until persisting history is merged).

Edit: actually this is much trickier now since you can do input.select -> input.select and mp.get_property_native('cursor-autohide') will no longer return the value from before opening the console. I think you can always retrieve the value in set_active() and do the toggling separately in bind_mouse() and unbind_mouse().

[verygoodlee]

I think you can always retrieve the value in set_active() and do the toggling separately in bind_mouse() and unbind_mouse().

retrieve value can also move into bind_mouse().
the global value has been reset to nil in unbind_mouse(), we can retrieve value if the global value is determined to be nil in bind_mouse().