New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

select.lua: asynchronous execution of ffmpeg subprocesses #15936

Open

dyphire wants to merge 2 commits into mpv-player:master from dyphire:select

+123 −39

Contributor

dyphire commented Feb 22, 2025

Avoid thread cloging

dyphire force-pushed the select branch from 6ccf125 to 2d08837 Compare

February 22, 2025 06:11

github-actions bot commented Feb 22, 2025 •

edited

Loading

Download the artifacts for this pull request:

Windows

macOS

dyphire force-pushed the select branch from 2d08837 to 40bb4f9 Compare

February 22, 2025 07:13

guidocella reviewed

View reviewed changes

player/lua/select.lua Outdated Show resolved Hide resolved

dyphire force-pushed the select branch from 40bb4f9 to 9e43224 Compare

February 22, 2025 07:25

guidocella reviewed

View reviewed changes

player/lua/select.lua Outdated Show resolved Hide resolved

dyphire force-pushed the select branch 2 times, most recently from c024695 to d154fc1 Compare

February 22, 2025 10:23

guidocella reviewed

View reviewed changes

player/lua/select.lua Outdated Show resolved Hide resolved

dyphire force-pushed the select branch 2 times, most recently from 86a9123 to 7256e6d Compare

February 22, 2025 10:35

guidocella reviewed

View reviewed changes

player/lua/select.lua Outdated Show resolved Hide resolved

guidocella reviewed

View reviewed changes

player/lua/select.lua Outdated Show resolved Hide resolved

dyphire force-pushed the select branch from 7256e6d to 5ada14b Compare

February 22, 2025 12:52

guidocella reviewed

View reviewed changes

player/lua/select.lua Show resolved Hide resolved

Contributor Author

dyphire commented Feb 22, 2025

I noticed that the original subtitle content parsing didn't address possible ass special content, resulting in a lot of content duplication

So I refactored the parsing of the subtitle content and now it will avoid repeated display of the same content at the same time. This reduced the number of subtitles displayed from 6000+ to 1366

Member

avih commented Feb 22, 2025

The async change should probably be in its own commit (unless you think it's tied closely with the other changes).

dyphire force-pushed the select branch from 5ada14b to 98236ae Compare

February 22, 2025 13:14

Contributor Author

dyphire commented Feb 22, 2025

The async change should probably be in its own commit (unless you think it's tied closely with the other changes).

I was refactoring while working on other problem issues and forgot to split the commit. Will redo it later.

dyphire force-pushed the select branch 3 times, most recently from d61d1ab to 1d842d5 Compare

February 22, 2025 13:46

guidocella reviewed

View reviewed changes

player/lua/select.lua Outdated Show resolved Hide resolved

guidocella reviewed

View reviewed changes

player/lua/select.lua Outdated Show resolved Hide resolved


          select.lua: asynchronous execution of ffmpeg subprocesses

2bf42d8

Avoid thread cloging

dyphire force-pushed the select branch 5 times, most recently from af1fe9b to ce1cd29 Compare

February 23, 2025 03:54

dyphire force-pushed the select branch from ce1cd29 to f8be4d4 Compare

February 23, 2025 04:09


          select.lua: refactor subtitle parse

fb3f8fb

Avoid repeated display of the same content at the same subtitle time

Keep blank lines for both lrc and srt formats

dyphire force-pushed the select branch from f8be4d4 to fb3f8fb Compare

February 24, 2025 04:52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet