demux_lavf: disable extension_picky for hls demuxer globally #15947
Conversation
|
Download the artifacts for this pull request: |
Added in FFmpeg/FFmpeg@91d96dc The user can still turn this on via demuxer-lavf-o=extension_picky=1 if they want to. This causes quite a few problems with many HLS sources where the codecs are not known at probe time for whatever reason. Youtube for instance shows "aac" audio codecs as "unknown". As an aside, the FFmpeg test is also buggy and leaks a nested connection for any playlist item that fails the extension check. mpv catches this and prints "Leaking 1 nested connections (FFmpeg bug)" for every HLS stream that has at least one stream that fails the extension check.
My worry is that if we hide those bugs, thy will live in ffmpeg forever. mpv is primary user of this ytdl to ffmpeg interaction. There are other users for sure, but mpv is one of the more popular one, as seen by the bug reports about this feature, that mention always mpv. (it's not easy to reproduce with standalone examples, because failures are likely with ytdl supported sites) |
Added in FFmpeg/FFmpeg@91d96dc
The user can still turn this on via demuxer-lavf-o=extension_picky=1 if they want to.
This causes quite a few problems with many HLS sources where the codecs are not known at probe time for whatever reason. Youtube for instance shows "aac" audio codecs as "unknown".
As an aside, the FFmpeg test is also buggy and leaks a nested connection for any playlist item that fails the extension check. mpv catches this and prints "Leaking 1 nested connections (FFmpeg bug)" for every HLS stream that has at least one stream that fails the extension check.