Skip to content

refactor(git): simplify staged diff validation logic #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mqyang56 merged 1 commit into from
Feb 26, 2026
Merged

refactor(git): simplify staged diff validation logic #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions src/git/gitService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,16 +40,12 @@ export class GitService {
async getStagedDiff(): Promise<string> {
const repo = this.getRepository();

if (repo.state.indexChanges.length === 0) {
const diff = await repo.diff(true);
if (!diff) {
throw new Error(
"No staged changes found. Stage some changes before generating a commit message."
);
}

const diff = await repo.diff(true);
if (!diff) {
throw new Error("Staged diff is empty");
}
return diff;
}

Expand Down