Disable audio and video autoplay

Fixes #9
mr-pennyworth · Feb 26, 2024 · 69f35e4 · 69f35e4
1 parent 80d4e9c
commit 69f35e4
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 5 deletions.
diff --git a/AlfredExtraPane.xcodeproj/project.pbxproj b/AlfredExtraPane.xcodeproj/project.pbxproj
@@ -471,7 +471,7 @@
 					"@executable_path/../Frameworks",
 				);
 				MACOSX_DEPLOYMENT_TARGET = 11.0;
-				MARKETING_VERSION = 0.1.4;
+				MARKETING_VERSION = 0.1.5;
 				ONLY_ACTIVE_ARCH = NO;
 				OTHER_CODE_SIGN_FLAGS = "--deep";
 				PRODUCT_BUNDLE_IDENTIFIER = mr.pennyworth.AlfredExtraPane;
@@ -492,7 +492,7 @@
 					"@executable_path/../Frameworks",
 				);
 				MACOSX_DEPLOYMENT_TARGET = 11.0;
-				MARKETING_VERSION = 0.1.4;
+				MARKETING_VERSION = 0.1.5;
 				ONLY_ACTIVE_ARCH = NO;
 				OTHER_CODE_SIGN_FLAGS = "--deep";
 				PRODUCT_BUNDLE_IDENTIFIER = mr.pennyworth.AlfredExtraPane;

diff --git a/AlfredExtraPane/Pane.swift b/AlfredExtraPane/Pane.swift
@@ -138,9 +138,16 @@ func makeWindow() -> NSWindow {
 }
 
 func makeWebView() -> WKWebView {
-  let configuration = WKWebViewConfiguration()
-  configuration.preferences.setValue(true, forKey: "developerExtrasEnabled")
-  return WKWebView(frame: .zero, configuration: configuration)
+  let conf = WKWebViewConfiguration()
+  conf.preferences.setValue(true, forKey: "developerExtrasEnabled")
+
+  // TODO: allow configuration from prefs.json
+  // we don't want the pane to autoplay audio from the loaded webpage.
+  // (ideally, we want to be able to configure it, but till then, the
+  // quick fix is to disable autoplay).
+  conf.mediaTypesRequiringUserActionForPlayback = .all
+
+  return WKWebView(frame: .zero, configuration: conf)
 }
 
 func injectCSS(_ html: String) -> String {