Skip to content

Make the DSL interpret sym nodes as ident nodes#671

Merged
Vindaar merged 1 commit intomratsim:masterfrom
fabricio-p:accept-sym-nodes
Nov 10, 2024
Merged

Make the DSL interpret sym nodes as ident nodes#671
Vindaar merged 1 commit intomratsim:masterfrom
fabricio-p:accept-sym-nodes

Conversation

@fabricio-p
Copy link
Contributor

No description provided.

@fabricio-p
Copy link
Contributor Author

I suspect that the usually nnkIdent nodes became sym nodes because I tried invoking the network macro inside a template. There could be a greater issue at play here (in the compiler) but I digress

@Vindaar
Copy link
Collaborator

Vindaar commented Nov 10, 2024

I suspect that the usually nnkIdent nodes became sym nodes because I tried invoking the network macro inside a template. There could be a greater issue at play here (in the compiler) but I digress

No, that's precisely what would happen in that context. It will only be ident if it is really in a fully untyped context.

@Vindaar
Copy link
Collaborator

Vindaar commented Nov 10, 2024

Thanks, looks good to me!

@Vindaar Vindaar merged commit 2535236 into mratsim:master Nov 10, 2024
metagn pushed a commit to metagn/Arraymancer that referenced this pull request Mar 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants