fix tests runner in older node versions

mrbar42 · Aug 17, 2021 · aeebe6a · aeebe6a
1 parent a04c912
commit aeebe6a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml
@@ -13,7 +13,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node: [ '8', '12', '14', '16' ]
+        node: [ '8', '10', '12', '14', '16' ]
     name: Node ${{ matrix.node }} Tests
     steps:
       - uses: actions/checkout@v2

diff --git a/tests/runner.js b/tests/runner.js
@@ -140,9 +140,14 @@ function asyncRunner() {
     let path = require.resolve(__dirname + '/' + test.child);
     let timer;
     let ended = false;
+    const args = [path];
     // unhandled rejections default to throw since v15, warn since v10
     // we make it the same for all versions so the result will be consistent.
-    let child = execFile('node', ["--unhandled-rejections=none", path], (err, stdout) => {
+    if (Number(process.version.substring(1).split('.')[0]) >= 10) {
+        args.unshift("--unhandled-rejections=none");
+    }
+
+    let child = execFile('node', args, (err, stdout) => {
         clearTimeout(timer);
         ended = true;
         if (err && /Error/.test(err.message)) {