Mrc-6813: Add Error page for fallback #23
+262
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absternator
requested review from
M-Kusumgar and
Copilot
and removed request for
Copilot
absternator
changed the title
Copilot finished reviewing on behalf of
absternator
November 12, 2025 15:08
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements comprehensive error handling by adding a custom error boundary page (+error.svelte) and enhancing server-side error logging in hooks.server.ts. The error page provides a user-friendly interface for common HTTP errors, while the handleError hook logs detailed error information with unique error IDs for support tracking.
Key Changes:
- Added
+error.svelteas a fallback error boundary that displays status codes, user-friendly messages, and navigation options - Implemented
handleErrorhook inhooks.server.tsto log errors with unique IDs and return sanitized messages for 500 errors - Added comprehensive test coverage for both the error page component and the server hooks
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/routes/+error.svelte | Error boundary component with status-specific messages and navigation actions |
| src/hooks.server.ts | Added handleError hook for centralized error logging with unique error IDs |
| src/tests/routes/error.svelte.spec.ts | Unit tests for error page component rendering |
| src/tests/hooks.server.spec.ts | Unit tests for handle and handleError hook functions |
| e2e/region.test.ts | E2E test verifying error page displays for non-existent regions |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
==========================================
- Coverage 97.04% 96.67% -0.38%
==========================================
Files 60 61 +1
Lines 2234 2255 +21
Branches 493 495 +2
==========================================
+ Hits 2168 2180 +12
- Misses 65 74 +9
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
M-Kusumgar
approved these changes
Nov 17, 2025
src/routes/+error.svelte
Outdated
Comment on lines
5
to
17
| const statusMessages: Record<number, string> = { | ||
| 404: 'Resource Not Found', | ||
| 500: 'Internal Server Error', | ||
| 403: 'Forbidden', | ||
| 401: 'Unauthorized' | ||
| }; | ||
| const statusDescriptions: Record<number, string> = { | ||
| 404: "The page you're looking for doesn't exist or has been moved.", | ||
| 500: "Something went wrong on our end. We're working to fix it.", | ||
| 403: "You don't have permission to access this resource.", | ||
| 401: 'You need to be authenticated to access this page.' | ||
| }; |
Contributor
There was a problem hiding this comment.
perhaps putting these together as one object? so its error code to { message, description }?
…ingle object for improved clarity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some extra error handling. It mainly adds the +error.svelte, which is an error boundary page that gets hit if there is an error during the load function.(can read more here. Also ive added some logic in
hooks.server.ts, this catches any unexpected errors and forwards them on logging the issue.(can read here)Testing:
spin up app and head to random page etc
/projects/wtf-random-nto see error page.