Skip to content

Commit

Permalink
Update Dockerfile
Browse files Browse the repository at this point in the history
  • Loading branch information
mrded authored Apr 25, 2017
1 parent 9616dde commit 9489f22
Showing 1 changed file with 16 additions and 7 deletions.
23 changes: 16 additions & 7 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,14 +1,23 @@
FROM node:6.10

COPY *.* /app/
COPY views/ /app/
COPY public /app/
LABEL maintainer "dmitry@demenchuk.me"
LABEL version="1.0"
LABEL description="If you need to convert text from one markup format into another, pandoc is your swiss-army knife."

WORKDIR /app/
# Create app directory
RUN mkdir -p /usr/src/pandoc-as-a-service
COPY . /usr/src/pandoc-as-a-service
WORKDIR /usr/src/pandoc-as-a-service

RUN apt-get update \
&& apt-get install -y pandoc \
&& npm install
# Install packages
RUN apt-get update --fix-missing
RUN apt-get install -y pandoc

# Clean up
RUN apt-get clean && rm -rf /var/lib/apt/lists/*

# Install service
RUN npm install

This comment has been minimized.

Copy link
@SISheogorath

SISheogorath Apr 26, 2017

Contributor

Splitting everything up into multiple run statements is a bad idea. Docker uses file system diffing for layer-to-layer differences. So if you delete something your container crows as much as it would grow when you add it.

Some tips for small images: https://www.shivering-isles.com/docker-minimize-your-containers-with-alpine-linux/#size

This comment has been minimized.

Copy link
@mrded

mrded Apr 26, 2017

Author Owner

Thanks. Didn't know about it


EXPOSE 8080

Expand Down

0 comments on commit 9489f22

Please sign in to comment.