New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Do not capitalize primitive types. #30461

Merged

Mugen87 merged 1 commit into mrdoob:dev from Mugen87:dev3

Feb 5, 2025

Collaborator

Mugen87 commented Feb 5, 2025

Related issue: #30445

Description

This PR ensures string, number, boolean and any are not capitalized in JSDoc anymore.


          Docs: Do not capitalize primitive types.

fd33f30

github-actions bot commented Feb 5, 2025

📦 Bundle size

Full ESM build, minified and gzipped.

	Before	After	Diff
WebGL	336.12 78.22	336.12 78.22	+0 B +0 B
WebGPU	516.99 143.53	516.99 143.53	+0 B +0 B
WebGPU Nodes	516.45 143.43	516.45 143.43	+0 B +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

	Before	After	Diff
WebGL	465.17 112.09	465.17 112.09	+0 B +0 B
WebGPU	588.99 159.73	588.99 159.73	+0 B +0 B
WebGPU Nodes	544.35 149.29	544.35 149.29	+0 B +0 B

Mugen87 merged commit 4f3c02b into mrdoob:dev

12 checks passed

Mugen87 added this to the r174 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet