Integration of Short.cm provider #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that Travis is likely to fail as Composer dropped support for HHVM |
mremi
reviewed
May 10, 2019
tests/Mremi/UrlShortener/Tests/Provider/ShortCm/ShortCmProviderTest.php
Outdated
Show resolved
Hide resolved
tests/Mremi/UrlShortener/Tests/Provider/ShortCm/ShortCmProviderTest.php
Outdated
Show resolved
Hide resolved
tests/Mremi/UrlShortener/Tests/Provider/ShortCm/ShortCmProviderTest.php
Outdated
Show resolved
Hide resolved
tests/Mremi/UrlShortener/Tests/Provider/ShortCm/ShortCmProviderTest.php
Outdated
Show resolved
Hide resolved
tests/Mremi/UrlShortener/Tests/Provider/ShortCm/ShortCmProviderTest.php
Outdated
Show resolved
Hide resolved
tests/Mremi/UrlShortener/Tests/Provider/ShortCm/ShortCmProviderTest.php
Outdated
Show resolved
Hide resolved
tests/Mremi/UrlShortener/Tests/Provider/ShortCm/ShortCmProviderTest.php
Outdated
Show resolved
Hide resolved
|
Could you please replace |
|
Could you please update |
|
Travis fails for PHP 7.2 and 7.3. @mremi As I'm not a Travis expert at all, can I hand fixing it over you? |
mremi
reviewed
May 23, 2019
| */ | ||
| public function __construct($apiKey, $domain) | ||
| { | ||
| $this->apiKey = $apiKey; |
|
Travis is failing because of a deprecation: |
|
I only have 7.0 and 7.1 available locally. I dont have time setting up a local container for PHP 7.2 or 7.3. My company is running through high season. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration of https://short.cm/api