Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove the marginfi account check at the end #247

Closed

Conversation

cxp-13
Copy link

@cxp-13 cxp-13 commented Sep 20, 2024

No description provided.

@jkbpvsc
Copy link
Member

jkbpvsc commented Sep 21, 2024

Closing as not stated why this is necessary.

@cxp-13
Copy link
Author

cxp-13 commented Sep 21, 2024

Closing as not stated why this is necessary.

The idea for this branch comes from #212.
I think checking the account status at the end of the function is redundant, so I commented it out. Do you mean to explain the reason when submitting the PR?

    // check!(
    //     !marginf_account.get_flag(DISABLED_FLAG),
    //     MarginfiError::AccountDisabled
    // );

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants