feat(mfi-v2-ui): new stake page #945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
k0beLeenders
approved these changes
Nov 6, 2024
|
|
||
| type ArenaIntegrationCardProps = { | ||
| lstBank?: ExtendedBankInfo; | ||
| goatBank?: ExtendedBankInfo; |
There was a problem hiding this comment.
should we make this a bit more general and call it token bank?
| <CardContent> | ||
| <ul className="space-y-2"> | ||
| <li className="flex items-center justify-between gap-1"> | ||
| <span className="text-muted-foreground">APY:</span> 25.15% |
There was a problem hiding this comment.
aha, I see why it is hardcoded
packages/mrgn-utils/src/mrgnUtils.ts
Outdated
| export function getTokenImageURL(bank: ExtendedBankInfo): string { | ||
| return `https://storage.googleapis.com/mrgn-public/mrgn-token-icons/${bank.info.rawBank.mint.toBase58()}.png`; | ||
| export function getTokenImageURL(bank: ExtendedBankInfo | PublicKey): string { | ||
| const mintAddress = (bank as ExtendedBankInfo).info?.rawBank.mint || bank; |
There was a problem hiding this comment.
wouldn't this throw if you try .info on a PublicKey?
maybe it would better to do instanceof
…y into stake page / calculator
…to fail and the other to succeed.
… fail and the other to succeed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New stake page with stake calculator.