Extensions and Resource-bugfix, build update#2
Open
arberg wants to merge 3 commits intomrmilu:masterfrom
Open
Conversation
added 3 commits
January 12, 2016 12:26
…to text, read color for non-deprecated ContextCompat, fixed Res annotations
Fixed resources (for real this time) Non-Editable text field Text Listener
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest commit removes resourcePrefix from attributes. I use Android studio preview 2.0 and gradle 1.5. When building with resourcePrefix it the attributes are not exported. I suspect this might be because Android does not export resources with resourcePrefix. I havn't been able to find any documentation by searching Google though. I left the resource prefix on strings which we don't need exported.
If you don't want to include the stripping of resourcePrefix,the two first commits still bring value, I believe.