Allow support for PHP Attributes with new context#1
Draft
iperaltamrmilu wants to merge 1 commit intomasterfrom
Draft
Allow support for PHP Attributes with new context#1iperaltamrmilu wants to merge 1 commit intomasterfrom
iperaltamrmilu wants to merge 1 commit intomasterfrom
Conversation
iperaltamrmilu
requested review from
carlos-mella,
jgarciamrmilu,
ppalomera and
rdacosta1996
rdacosta1996
approved these changes
Apr 2, 2025
Member
|
Sounds good but I want to see it in depth. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Field mrmilu_block_plugin allows to have a list with custom Block Plugins adding allow_as_block_plugin_field in their definitions.
This functionality is not implemented in PHP Attributes, so using context_definitions we create a new context to have the same behaviour.