PoC: use raw jsi::Value prop w/ fabric views
#386
Conversation
Includes changes from: facebook/react-native#48047
0.76.2 fixed this error: facebook/react-native#46208
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| "pods": "cd ios && bundle exec pod install && rm -rf .xcode.env.local", | ||
| "pods": "cd ios && bundle exec pod install", |
There was a problem hiding this comment.
btw: without this change i can't run the example app. I am pretty sure that deleting the .xcode.env.local is wrong.
Will remove this change in a moment though
|
Okay, i am still missing one piece, seems like the props parser currently removes our prop:
fixing … |
convert to kotlin still missing
prop updates are broken yet
Moved code to set props to state to adopt() as thats always called for creation & updates
…c/views-with-nativestate-props
|
@mrousavy android is good as well now. In the same phase in which the new props are updated we get the update on the java side, so I think there is no weird back and forth. We have to use the state wrapper on android as this is the only thing thats shared between c++ and java for the view manager (props are always eagerly converted to folly::dynamic). |
|
Updated 👍 |
hannojg
changed the title
jsi::Value prop w/ fabric viewsjsi::Value prop w/ fabric views
| } | ||
|
|
||
| export const CustomView: HostComponent<NativeProps> = | ||
| NativeComponentRegistry.get<NativeProps>('CustomView', () => viewConfig) |
There was a problem hiding this comment.
Why does requireNativeComponent(..) not work here?
There was a problem hiding this comment.
it might, we'd have to test this
How to setup:
(I had to update to RN >= 0.76.2 to fix a build issue where some yoga header could not be found)
git clean -dfXbun inpx patch-packagebun run buildPRs in react-native to get it work:
RawPropsParseradduseRawPropsJsiValueparameter facebook/react-native#48231RawPropsParseras optional parameter to Concrete-/ComponentDescriptor facebook/react-native#48232RawValuedirectly fromjsi::Valuefacebook/react-native#48047getStateforStateWrapperImplfacebook/react-native#48255