build(windows): fix builder-bob failing to find tsc

[tido64]

Nitro currently fails to build on a Windows machine:

$ bun run build
$ bun run --cwd packages/react-native-nitro-modules build && bun run --cwd packages/nitrogen build && bun run --cwd packages/react-native-nitro-image build
$ rm -rf lib && bun typecheck && bob build
$ tsc --noEmit
ℹ Building target commonjs
ℹ Cleaning up previous build at lib\commonjs
ℹ Building target module
ℹ Cleaning up previous build at lib\module
ℹ Building target typescript
ℹ Cleaning up previous build at lib\typescript
ℹ Compiling 10 files in src with babel
ℹ Compiling 10 files in src with babel
ℹ Generating type definitions with tsc
✖ The tsc binary doesn't seem to be installed at D:\nitro\node_modules\.bin\tsc. Please specify the correct path in options or remove it to use the workspace's version.
D:\nitro\node_modules\react-native-builder-bob\lib\targets\typescript.js:194
    throw new Error('Failed to build definition files.');
          ^

Error: Failed to build definition files.
    at build (D:\nitro\node_modules\react-native-builder-bob\lib\targets\typescript.js:194:11)
    at async buildTarget (D:\nitro\node_modules\react-native-builder-bob\lib\index.js:416:7)

Node.js v20.17.0
error: script "build" exited with code 1
error: script "build" exited with code 1

The reason is because we're specifying a Unix-specific path in package.json. Removing it makes things build, but we get this warning instead:

⚠ Failed to locate tsc in the workspace. Falling back to the binary found in PATH at D:\nitro\node_modules\.bin\tsc.EXE. Consider adding typescript to your devDependencies or specifying the tsc option for the typescript target.

Even after I've added typescript to devDependencies, this warning still appears. I suspect it's a bug in builder-bob, but I haven't looked into it.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nitro-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 3, 2024 5:47pm

[mrousavy]

@chrispader can you confirm that this will still work with our monorepo setup?

[chrispader]

hmm, the reason we specify the tsc location is because otherwise react-native-builder-bob will warn that it uses the global typescript package.

Adding the typescript dependency will prevent hoisting of the package in the root, but BuilderBob can find it.

We can either not hoist it, or fix this for non-unix platforms

[mrousavy]

I would prefer to use the same TypeScript version for all modules here to avoid any version conflicts, so I think hoisting is the best approach right?

[chrispader]

yes, i'd also agree

[mrousavy]

I'm running into the same issue now on Windows.. 😅

[fax1ty]

Should this be cancelled in favor of packages/react-native-nitro-modules/package.json?