Skip to content

chore: update react-native@0.66 and fix Use of undeclared identifier 'ShareableValue' #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: update react-native@0.66 and fix Use of undeclared identifier 'ShareableValue' #37

wants to merge 1 commit into from

Conversation

numandev1
Copy link

No description provided.

@numandev1 numandev1 force-pushed the chore/update-react-native@0.66 branch from 72b1353 to dfb1bac Compare September 30, 2021 20:23
@mrousavy
Copy link
Owner

mrousavy commented Oct 4, 2021

how is the ShareableValue error fixed? by importing it at last?

@numandev1
Copy link
Author

@mrousavy Yes, fixed by import #include <RNReanimated/ShareableValue.h after #include <RNReanimated/RuntimeManager.h>

@goleary
Copy link

goleary commented Dec 27, 2021 •
edited
Loading

@mrousavy I'm also experiencing this error use of undeclared identifier 'ShareableValue' which after locally moving the include of SharedValue.h after RuntimeManager.h resolves the build error.

It would be awesome to merge/ship this PR so that I don't have to patch/modify locally.

We're using react-native 0.66.0.

Thanks!

@callaars
Copy link

callaars commented Feb 17, 2022 •
edited
Loading

Can we give this some attention because this is preventing me of using the library (unmodified)? Personally I'd get rid of the package changes though, and just focus on the .cpp.

callaars
callaars reviewed Feb 17, 2022
View reviewed changes
cpp/RNMultithreadingInstaller.cpp
#include <RNReanimated/Scheduler.h>
#include <RNReanimated/ShareableValue.h>
#include <RNReanimated/RuntimeManager.h>
#include <RNReanimated/ShareableValue.h>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to do the same on line #14 btw.

@whalemare whalemare mentioned this pull request Apr 23, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@callaars callaars callaars left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@numandev1 @mrousavy @goleary @callaars