feat: Add the option to enable idle timer on iOS #3416
+15
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hey @mrousavy did you have a chance to take a look at this yet? Since my use case is for timing out for barcode scanning, would it make sense to disable idle timer only when a video is being recorded (and remove this prop?) I think I saw the disable idle timer was only added for not sleeping when a video is being recorded so let me know what you think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Added support for enabling the idle timer while the camera is active on iOS. Use case is I am using this for barcode scanning and I want the phone to go to sleep if the user prefers it, in case they leave their phone on and leave it alone. On android it seems like the phone does go to sleep when left alone so I have left it as is.
Changes
Added
enableIdleTimerprop (defaults to false) and implemented it for iOS.Tested on
Tested both with enableIdleTimer set to true as well as false to see if everything works as expected.
Related issues