Replace logging of errors

mrueg · Sep 23, 2024 · 7c1a395 · 7c1a395
1 parent 63c2a0c
commit 7c1a395
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/main.go b/main.go
@@ -44,7 +44,7 @@ func main() {
 
 	var metricsPath = "/metrics"
 	logger = promslog.New(promslogConfig)
-	logger.Debug("Starting SCP Exporter version "+version.Version+" git "+version.Revision)
+	logger.Debug("Starting SCP Exporter version " + version.Version + " git " + version.Revision)
 	client := soap.NewClient(netcupWSUrl)
 	wsclient := scpclient.NewWSEndUser(client)
 	scpCollector := metrics.NewScpCollector(wsclient, logger, loginName, password)
@@ -66,7 +66,7 @@ func main() {
 	}
 	landingPage, err := web.NewLandingPage(landingConfig)
 	if err != nil {
-		logger.Error("failed to create landing page", slog.Any("error", err))
+		logger.Error("failed to create landing page", "error", err.Error())
 		os.Exit(1)
 	}
 	http.Handle(metricsPath, promhttp.HandlerFor(

diff --git a/pkg/metrics/metrics.go b/pkg/metrics/metrics.go
@@ -6,8 +6,8 @@
 package metrics
 
 import (
-	"log/slog"
 	"encoding/xml"
+	"log/slog"
 	"strconv"
 	"strings"
 	"time"
@@ -126,7 +126,7 @@ func (collector *ScpCollector) Collect(ch chan<- prometheus.Metric) {
 	}
 	genericResponse, err := collector.client.GetVServers(genericRequest)
 	if err != nil {
-		collector.logger.Error("Unable to get servers", slog.Any("error", err))
+		collector.logger.Error("Unable to get servers", "error", err.Error())
 	}
 
 	debug, _ := xml.Marshal(genericResponse)
@@ -145,7 +145,7 @@ func (collector *ScpCollector) Collect(ch chan<- prometheus.Metric) {
 		debug, _ := xml.Marshal(infoResponse)
 		collector.logger.Debug(string(debug))
 		if err != nil {
-			collector.logger.Error("Unable to get Server Information", slog.Any("error", err))
+			collector.logger.Error("Unable to get Server Information", "error", err.Error())
 		}
 		// Create CPU / Memory info metrics
 		ch <- prometheus.MustNewConstMetric(collector.cpuCores, prometheus.GaugeValue, float64(infoResponse.Return_.CpuCores), *vserver)
@@ -216,7 +216,7 @@ func (collector *ScpCollector) Collect(ch chan<- prometheus.Metric) {
 		// Create start time metric
 		uptime, err := parseUptimeString(&infoResponse.Return_.Uptime)
 		if err != nil {
-			collector.logger.Error("Unable to parse uptime", slog.Any("error", err))
+			collector.logger.Error("Unable to parse uptime", "error", err.Error())
 		}
 		ch <- prometheus.MustNewConstMetric(collector.serverStartTime, prometheus.GaugeValue, float64(time.Now().Add(-uptime).Unix()), *vserver)
 	}