Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,13 @@ jobs:
test:
strategy:
matrix:
os: ["ubuntu-latest", "windows-latest", "macos-latest"]
os: ["ubuntu-latest", "windows-latest", "windows-11-arm", "macos-latest"]
py: ["3.14-dev", "3.13", "3.12", "3.11", "3.10", "3.9"]

exclude:
- os: windows-11-arm
py: "3.9"
- os: windows-11-arm
py: "3.10"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you want add them into wheel.yml?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@methane, yeah I have missed that out. Thanks for pointing out
The reason I have excluded those builds is that Official Python distribution for Windows ARM64 starts from 3.11

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please look again at the diff of the two files being edited in this PR.

You are adding windows-11-arm to excludes, while window-11-arm is not included in the matrix of this file.
You probably forgot to add windows-11-arm to the matrix of this file, or you intended to add excludes to the other file, not this one.

runs-on: ${{ matrix.os }}
name: Run test with Python ${{ matrix.py }} on ${{ matrix.os }}

Expand All @@ -29,8 +33,8 @@ jobs:
- name: Prepare
shell: bash
run: |
pip install -U pip
pip install -r requirements.txt pytest
python -m pip install -U pip
python -m pip install -r requirements.txt pytest

- name: Build
shell: bash
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/wheel.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
strategy:
matrix:
# macos-13 is for intel
os: ["ubuntu-24.04", "ubuntu-24.04-arm", "windows-latest", "macos-13", "macos-latest"]
os: ["ubuntu-24.04", "ubuntu-24.04-arm", "windows-latest", "windows-11-arm", "macos-13", "macos-latest"]
runs-on: ${{ matrix.os }}
name: Build wheels on ${{ matrix.os }}

Expand All @@ -33,7 +33,7 @@ jobs:
env:
CIBW_TEST_REQUIRES: "pytest"
CIBW_TEST_COMMAND: "pytest {package}/test"
CIBW_SKIP: "pp* cp38-*"
CIBW_SKIP: "pp* cp38-* cp39-win_arm64 cp310-win_arm64"

- name: Build sdist
if: runner.os == 'Linux' && runner.arch == 'X64'
Expand Down
Loading