Attempt to replicate the forward ref work #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upon writing tests, I noticed that my original version didn't support various import patterns this takes care of at least two cases, but i think a different approach may be even better?
mskelton
reviewed
Aug 4, 2023
|
@krishnaglick thanks for this, and for giving me co-author credit! i was going to get back to it when you asked, as the company I had worked on it for had asked me to stop, but I see you got to it first! |
Apologies! I just was not sure it was going to move anytime soon. Thank you for doing this!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #50 seems dead in the water I'm trying to get it moving again.