dts: msm8974: Add support for Samsung Galaxy Note 3 (hlte) #347
Conversation
|
|
||
| / { | ||
| // This is used by the bootloader to find the correct DTB | ||
| qcom,msm-id = <0x7E01FF01 7 0>, <0xB801FF01 7 0>, <0xB901FF01 7 0>; |
There was a problem hiding this comment.
| qcom,msm-id = <0x7E01FF01 7 0>, <0xB801FF01 7 0>, <0xB901FF01 7 0>; | |
| qcom,msm-id = <0x7E01FF01 7 0>; |
the three in here were: msm8974(126), apq8074(184), msm8274(185), per the highest byte and qcom,ids.h. I don't think you need apq and the 3g-only chip here...
There was a problem hiding this comment.
Got it.
Hadn't looked through what they were back then; just kept all three as they were in the dts.
| qcom,board-id = <1 0x0>; | ||
| qcom,msm-id = <126 0x10001>; |
There was a problem hiding this comment.
| qcom,board-id = <1 0x0>; | |
| qcom,msm-id = <126 0x10001>; |
this looks bogus and I really don't think any samsung dts would have this pair...
There was a problem hiding this comment.
That's what I thought. Looked too generic to me, although my mind went "who knows?" at that time.
Those were based on lk2nd's log and my quick run-through of the documentation for board-id. However, I just can't find anything on board-id for non-Pro MSM8974.
There was a problem hiding this comment.
lk2nd has logged what it has read from the hardware fuses using the qcom's code that most oems also use. However samsung is one of the oems who doesn't use that code and instead has their own msm-id scheme with the long 4 byte value + rev number. If you want to make sure downstream works, you /do/ need to use those properties to override lk2nd's guess but you need to set the desired values from downstream dts, i.e. like here:
lk2nd/dts/msm8916/msm8916-samsung-r08.dts
Lines 48 to 49 in b02d758
which is usually only necessary if the rev you need is different from the rev that samsung's bl picks in lk2nd dts, since lk2nd tries to find and reuse samsung's bootloader choice when it can. (not sure how robust is that though)
It's a draft for now, as I won't be online for a while (till May).
Why haven't I squashed? Later... Don't want to set up Git on devices I use atm.
lk_log.txt